DRY out AuthorizationsController#render_success

In our own deployment, we have some custom exception handling around the `create`` method. By calling the more "public" `create` method in `render_success`, we get to have a _single_ code path that also supports `skip_authorization?` and `can_authorize_response?`. The code on L35 is identical to L16. That suggests identical intent, but not always. This might be coincidental, in which case, the pull request should be declined.
doorkeeper-gem · May 6, 2024 · c2a2dbc · c2a2dbc
1 parent 8626b85
commit c2a2dbc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@ User-visible changes worth mentioning.
 ## main
 
 Add your entry here.
+- [#????] DRY out AuthorizationsController#render_success
 
 ## 5.7.0
 

diff --git a/app/controllers/doorkeeper/authorizations_controller.rb b/app/controllers/doorkeeper/authorizations_controller.rb
@@ -32,7 +32,7 @@ def destroy
 
     def render_success
       if skip_authorization? || can_authorize_response?
-        redirect_or_render(authorize_response)
+        create
       elsif Doorkeeper.configuration.api_only
         render json: pre_auth
       else