Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migration(android): billingClient 7.0.0 #2764

Merged
merged 7 commits into from
Jun 21, 2024
Merged

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jun 12, 2024

@hyochan hyochan added 🤖 android Related to android 🚽 migration Activities due to changes in framework labels Jun 12, 2024
Copy link

github-actions bot commented Jun 12, 2024

Risk Level 2 - /home/runner/work/react-native-iap/react-native-iap/android/src/amazon/java/com/dooboolab/rniap/RNIapAmazonListener.kt

The receiptToMap function is a useful addition for mapping receipt data to a WritableMap. However, ensure that all fields are correctly mapped and consider adding null checks where necessary to avoid potential NullPointerException.


Risk Level 3 - /home/runner/work/react-native-iap/react-native-iap/android/src/amazon/java/com/dooboolab/rniap/RNIapAmazonModule.kt

  1. The initConnection method's promise.safeReject should ensure that the error message is clear and actionable.
  2. The deepLinkToSubscriptions method should handle potential exceptions when starting activities to avoid crashes.

Risk Level 3 - /home/runner/work/react-native-iap/react-native-iap/android/src/play/java/com/dooboolab/rniap/RNIapModule.kt

  1. The ensureConnection method's nested promise handling is complex and could benefit from additional error handling and logging.
  2. The buyItemByType method should ensure that all parameters are validated before proceeding with the purchase flow to avoid runtime errors.

🛠️ The receiptToMap function is a useful addition but needs null checks to avoid potential NullPointerException.

⚠️ The initConnection method should have clear and actionable error messages, and the deepLinkToSubscriptions method needs exception handling to prevent crashes.

🔍 The ensureConnection method's nested promise handling is complex and requires better error handling and logging, while the buyItemByType method should validate all parameters to avoid runtime errors.


Powered by Code Review GPT

@@ -6,7 +6,7 @@ RNIap_buildToolsVersion=33.0.0
RNIap_ndkversion=23.1.7779620
RNIap_playServicesVersion=18.1.0
RNIap_amazonSdkVersion=3.0.4
RNIap_playBillingSdkVersion=6.1.0
RNIap_playBillingSdkVersion=7.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyochan hyochan merged commit 2001058 into main Jun 21, 2024
4 checks passed
@hyochan hyochan deleted the migration/billingclient-7.0.0 branch June 21, 2024 06:07
hyochan pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 🚽 migration Activities due to changes in framework 🕵️‍♂️ need more investigation Need investigation on current issue 📜 release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant