Add a Dockerfile to run gitsome in a Docker container #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.20% (diff: 100%)@@ master #99 diff @@
==========================================
Files 34 34
Lines 2105 2105
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2004 2004
Misses 101 101
Partials 0 0
|
|
Hi @l0rd, thanks for the pull request! Could you also update the README with Docker install instructions?
|
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
|
@donnemartin I've done what you've asked. Note that I'm using my Docker hub repository in the doc: $ docker run -ti --rm mariolet/gitsome You will probably want to use another Docker hub repository with an automated build. |
donnemartin
reviewed
Dec 4, 2016
| @@ -121,7 +121,8 @@ For no color, set the value(s) to `None`. `white` can appear as light gray on s | |||
|
|
|||
| ## Available Platforms | |||
|
|
|||
| `gitsome` is available for Mac, Linux, Unix, and [Windows](#windows-support). | |||
| `gitsome` is available for Mac, Linux, Unix, [Windows](#windows-support) and | |||
| [Docker](#running-as-docker-container). | |||
There was a problem hiding this comment.
Can we combine lines 124 and 125 into a single line?
| @@ -176,6 +177,7 @@ For no color, set the value(s) to `None`. `white` can appear as light gray on s | |||
| * [Installation](#installation) | |||
| * [Pip Installation](#pip-installation) | |||
| * [Virtual Environment Installation](#virtual-environment-installation) | |||
| * [Running as Docker container](#running-as-docker-container) | |||
There was a problem hiding this comment.
Can we capitalize "Container"?
| @@ -548,6 +550,34 @@ To deactivate the `gitsome` `virtualenv`, run: | |||
|
|
|||
| $ deactivate | |||
|
|
|||
| ### Running as Docker Container | |||
There was a problem hiding this comment.
Should this be "Running as a Docker Container"? If we make this change, please update line 180
donnemartin
changed the title
|
@l0rd Thank you! |
donnemartin
added a commit
that referenced
this pull request
Dec 26, 2016
Fix review comments in #99.
donnemartin
added a commit
that referenced
this pull request
Dec 26, 2016
Fix review comments in #99.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mario Loriedo mario.loriedo@gmail.com