Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #147: Gracefully ignore missing avatar image #148

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Fix #147: Gracefully ignore missing avatar image #148

merged 1 commit into from
Feb 12, 2019

Conversation

kBite
Copy link
Contributor

@kBite kBite commented Aug 10, 2018

Replacing exit() with return results in displaying the error message in place
of the missing avatar image without stopping execution of 'gitsome'.

@kengelhardt-godaddy
replace exit() with return (donnemartin#147)
ef1c42e 
Replacing exit() with return results in displaying the error message in place
of the missing avatar image *without* stopping execution of 'gitsome'.
@codecov-io
Copy link

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files          34       34           
  Lines        2112     2112           
=======================================
  Hits         2008     2008           
  Misses        104      104

@kBite
Copy link
Contributor Author

kBite commented Aug 10, 2018 •
edited
Loading

Drawback of this solution is an error message displayed everytime gh is run:

$  gh me
File not found: /home/kbite/.gitsomeconfigavatar.png
Followers: 0 | Following: 0
...

Maybe dropping the error message would be nicer.

@kBite kBite mentioned this pull request Aug 11, 2018
Closed
@donnemartin donnemartin changed the title replace exit() with return (#147) Fix #147: Gracefully ignore missing avatar image Feb 12, 2019
@donnemartin donnemartin merged commit 77f599e into donnemartin:master Feb 12, 2019
@donnemartin
Copy link
Owner

@kBite thank you!

@kBite kBite deleted the gracefully-ignore-missing-avatar branch February 13, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnemartin donnemartin donnemartin approved these changes

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kBite @codecov-io @donnemartin @kengelhardt-godaddy