Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape script path #54

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Escape script path #54

merged 1 commit into from
Jul 3, 2023

Conversation

donatj
Copy link
Owner

@donatj donatj commented Jul 3, 2023

If the path to vendor/ contains spaces, the script is incorrectly passed to the PHP server as two arguments. Thanks @SiestaCat

Fixes #53

@donatj
Copy link
Owner Author

donatj commented Jul 3, 2023

Verified the fix works on my Windows laptop. 👍

@donatj donatj merged commit 58cec8a into master Jul 3, 2023
30 checks passed
@donatj donatj deleted the fix/spaces-in-pathname branch July 3, 2023 15:58
@donatj donatj changed the title Escape path Escape script path Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add escapeshellarg around script path
1 participant