Update staticcheck x GitHub action guide

[novalagung]

Changelogs:

• Use the GitHub actions/checkout@v4 instead of the old one. also, remove the fetch-depth property as the default is already set to 1.
• Fix the go versions in the example. the go v1.16.x is not supported by staticcheck v2022.1.1
  • use go v1.21.x & v1.22.x instead
  • reference: staticcheck installation fails with go1.16 #1251 (comment)
• adjust space/indentation

[novalagung]

friendly ping for @dominikh, kindly review this PR, thanks!

[ccoVeille]

LGTM 👍

One remark anyway. Maybe I missed it, but I think this page should mention it's important to set up and use dependabot/renovate/whatever to keep this action update.

First. It would be better, and safer for everyone.

Then even if documentation is obsolete (because newer version of actions are available) and copy pasted, it will be fixed automatically.

[dominikh]

but I think this page should mention it's important to set up and use dependabot/renovate/whatever to keep this action update.

I do not advocate the use of Dependabot or similarly noisy tools that desire to update dependencies for the sake of updating them.

[ccoVeille]

but I think this page should mention it's important to set up and use dependabot/renovate/whatever to keep this action update.

I do not advocate the use of Dependabot or similarly noisy tools that desire to update dependencies for the sake of updating them.

That's right. It's definitely noisy. But somehow useful, otherwise it won't be everywhere. But that's a another topic 😅

Stepping out about the need to use such a not, my remark stays. The documentation could mention the example provided in the markdown should mention it may be out of date, and people should adapt to use latest version.

[dominikh]

I will probably switch to using latest, stable etc in the examples, and document that preferably people pin to specific versions instead. I'd much rather people ignore the advice to pin and run newer versions when they don't intend to than that people ignore the advice to update regularly and run older versions.

Plus I'm getting tired of having to update examples.

[ccoVeille]

That's a good approach.