Add readme command #313
Merged
Add readme command #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to make one small tweak and then merge: if you specify a section that doesn't exist in a readme, this still passes the README content through mdast but doesn't add the API section. I think it should exit 1 in this case. |
|
Yep, good point. |
|
@tmcw ^ merged your PR to |
|
👍 merging. |
rhendric
pushed a commit
to rhendric/documentation
that referenced
this pull request
Sep 15, 2022
* Explain why Orphan Instances are forbidden * review feedback * Review feedback - Add explicit example * Fix uniqueness typo * Fix another uniques
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #261
Chose to pull this into the codebase rather than referencing a separate
documentation-readmepackage because:buildcommandmdast-util-inject, it's pretty slim.cc @tmcw