Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Query::toIndexedIterable to honor INDEX BY construct #9099

Closed
wants to merge 2 commits into from
Closed

Add new Query::toIndexedIterable to honor INDEX BY construct #9099

wants to merge 2 commits into from

Conversation

ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Oct 6, 2021 •
edited
Loading

Fix the problem explained in #8927 as a feature

Alternative implementation as a bugfix in #9098

@ajgarlag ajgarlag mentioned this pull request Oct 6, 2021
Merged
@ajgarlag ajgarlag marked this pull request as ready for review October 6, 2021 07:43
@ajgarlag ajgarlag force-pushed the feature-indexed-iterable branch 2 times, most recently from 8fb2c1d to 3fd3af2 Compare October 7, 2021 06:07
@ajgarlag
Copy link
Contributor Author

ajgarlag commented Oct 7, 2021

After reviewing the code, I've found the IterableTester class that is used to ensure that results from Query::getResult and Query::toIterable must be equivalent. This does not occurs when using INDEX BY construct, so it's finally a bug.

Closing in favor of #9098.

@ajgarlag ajgarlag closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajgarlag