Add explicit @return type next to #[ReturnTypeWillChange]
#8905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
ret-types
branch
3 times, most recently
from
1206cd7
to
fca1f52
Compare
greg0ire
reviewed
Aug 10, 2021
| @@ -82,6 +82,8 @@ protected function configure() | |||
|
|
|||
| /** | |||
| * {@inheritdoc} | |||
| * | |||
| * @return int | |||
There was a problem hiding this comment.
Why is this needed for Symfony commands? This return type is not inherited from a native type like Countable or ArrayIterator, I thought this was only about native types. Isn't it?
There was a problem hiding this comment.
When used with DebugClassLoader, this saves a deprecation: @return means the same as #[ReturnTypeWillChange] to it.
There was a problem hiding this comment.
Ok, I thought DebugClassLoader wouldn't need it in the first place, since no stubs are involved, only normal PHP files. Apparently that's not the case.
greg0ire
approved these changes
Aug 10, 2021
SenseException
approved these changes
Aug 10, 2021
|
Thanks @nicolas-grekas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as doctrine/collections#280