Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate EntityRepository#clear() #7928

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Deprecate EntityRepository#clear() #7928

merged 1 commit into from
Dec 9, 2019

Conversation

kokspflanze
Copy link
Contributor

@kokspflanze kokspflanze commented Nov 27, 2019 •
edited by greg0ire
Loading

clear with entity class, generate a deprecated warning.

maybe better to remove the class name.

Closes #7925 , Closes #7922

lcobucci
lcobucci suggested changes Nov 28, 2019
View reviewed changes
Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution here! Just a few minor things and we should also add a test verifying the deprecation message (if we keep it).

lib/Doctrine/ORM/EntityRepository.php Outdated Show resolved Hide resolved
lib/Doctrine/ORM/EntityRepository.php Show resolved Hide resolved
@lcobucci lcobucci changed the base branch from 2.7 to 2.8.x November 28, 2019 20:37
@lcobucci lcobucci added this to the 2.8.0 milestone Nov 28, 2019
@lcobucci lcobucci changed the title clear with entity-class in entity-repository Deprecate EntityRepository#clear() Dec 9, 2019
@lcobucci lcobucci self-assigned this Dec 9, 2019
This was referenced Dec 9, 2019
Closed
Closed
@lcobucci lcobucci merged commit 9891477 into doctrine:2.8.x Dec 9, 2019
@svenkrefeld svenkrefeld mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire left review comments

@lcobucci lcobucci lcobucci approved these changes

@SenseException SenseException SenseException approved these changes

Assignees

@lcobucci lcobucci

Labels
Deprecation
Projects
None yet
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kokspflanze @lcobucci @greg0ire @SenseException