-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for entity namespaces (Foo:Bar) #6935
Remove support for entity namespaces (Foo:Bar) #6935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'm using this notation in DQL rather than FQCN as they can be quite long. Take a look at following:
Removing this feature will make using DQL without builder quite cumbersome I think |
The issue with entity namespaces is that they're solving a problem that doesn't exist anymore (it did back then when Doctrine 2.0 was released for PHP 5.3,
would become:
And with query builder, you won't even need string concatenation:
|
c269872
to
a4e32b7
Compare
ffe4c72
to
f304f34
Compare
f304f34
to
63cb801
Compare
Finally ready for shipping. |
Another possibly controversial PR removing existing feature. Entity namespaces are basically obsolete since PHP 5.5 released 4.5 years ago and are superseded by much safer
::class
pseudo-constant, which is refactoring- and autocomplete-friendly in IDEs.