Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6613 #6614 correct handling of new elements added to an initialized (yet dirty) collection #6616

Merged
merged 23 commits into from
Aug 11, 2017
Merged

#6613 #6614 correct handling of new elements added to an initialized (yet dirty) collection #6616

merged 23 commits into from
Aug 11, 2017

Commits on Aug 11, 2017

  1. It added the unit test #6613

    @Sysaninster
    Sysaninster committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    874d60d View commit details
    Browse the repository at this point in the history

  2. #6613 #6614 simplifying entity definition - using auto-assigned strin… 

    …g identifiers to reduce moving parts
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    594e60d View commit details
    Browse the repository at this point in the history

  3. #6613 #6614 better test specification - removing useless assertions

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    0a1a841 View commit details
    Browse the repository at this point in the history

  4. #6613 #6614 smashing entity definitions into the test

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    112a402 View commit details
    Browse the repository at this point in the history

  5. #6613 #6614 removing dedicated DDC6613 model directory

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    625f792 View commit details
    Browse the repository at this point in the history

  6. #6613 #6614 CS - applying @group annotation to the test

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    c195064 View commit details
    Browse the repository at this point in the history

  7. #6613 #6614 rewrote test logic to be less magic-constant-dependent

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    eca1d6b View commit details
    Browse the repository at this point in the history

  8. #6613 #6614 remove superfluous mappings

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    a4e547b View commit details
    Browse the repository at this point in the history

  9. #6613 #6614 correcting column mapping (was integer, should be `stri… 

    …ng`), segregating phone creation away
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    80f12ed View commit details
    Browse the repository at this point in the history

  10. #6613 #6614 removing phone/user specifics, using ORM naming for assoc… 

    …iations
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    8c4b5a4 View commit details
    Browse the repository at this point in the history

  11. #6613 #6614 removing IDE-generated header

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    d2c9b22 View commit details
    Browse the repository at this point in the history

  12. #6613 #6614 adding assertions about collection initialization and dir… 

    …ty status
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    5e2257d View commit details
    Browse the repository at this point in the history

  13. #6613 #6614 after initialization, the collection should be dirty anyway

    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    1fc7f81 View commit details
    Browse the repository at this point in the history

  14. #6613 #6614 ensuring that only newly added items that weren't loaded … 

    …are restored in the dirty state of the collection
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    d44e6e1 View commit details
    Browse the repository at this point in the history

  15. #6613 #6614 correcting broken test that isn't using objects against a… 

    … `PersistentCollection`
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    031e79e View commit details
    Browse the repository at this point in the history

  16. #6613 #6614 correcting broken test that isn't using objects against a… 

    … `PersistentCollection`
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    345cf1a View commit details
    Browse the repository at this point in the history

  17. #6613 #6614 #6616 moved integration test basics to a unit test that v… 

    …erifies basic dirty collection initialization semantics
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    04a5b12 View commit details
    Browse the repository at this point in the history

  18. #6613 #6614 #6616 initializing a dirty collection that has new items … 

    …that are also coming from initialization data de-duplicates new and persisted items
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    93c4064 View commit details
    Browse the repository at this point in the history

  19. #6613 #6614 #6616 removing repeated PersistentCollectionTest chunks… 

    … of code
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    b064fe3 View commit details
    Browse the repository at this point in the history

  20. Add failing test for dirty flag

    @alcaeus
    alcaeus committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    1174ec6 View commit details
    Browse the repository at this point in the history

  21. #6613 #6614 #6616 ensuring that the collection is marked as non-dirty… 

    … if all new items are contained in the initialized ones
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    a2ca6bb View commit details
    Browse the repository at this point in the history

  22. #6613 #6614 #6616 removing DDC6613 test, which was fully ported to un… 

    …it tests
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    3579997 View commit details
    Browse the repository at this point in the history

  23. #6613 #6614 #6616 minor performance optimisations around the new `res… 

    …toreNewObjectsInDirtyCollection` implementation
    @Ocramius
    Ocramius committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    004ac51 View commit details
    Browse the repository at this point in the history