Fix DDC767Test failing on php7 + pg94 #1374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure happens when running the full suite or even just:
see: https://revive.beccati.com/bamboo/browse/PHP-DOCPG-MAS-164/log
For reference:
I wasn't able to replicate with other PHP versions. On PHP7, running
tests/Doctrine/Tests/ORM/Functional/Ticket
yields 20, 21 and 22 as group IDs, rather than 1, 2, 3. Maybe some cleanup isn't run?Removing hardocoded IDs seems a sensible thing to do anyway.