Add failing unit test related to DBAL-1063 #743
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DBAL-1074 We use Jira to track the state of pull requests and the versions they got |
|
I've added a second test that produces the exception shown in the ticket |
| $tableNew->dropIndex('text_idx'); | ||
| $tableNew->addIndex(array('test'), 'duplicate'); | ||
| $comparator = new Comparator; | ||
| $this->_sm->alterTable($comparator->diffTable($tableFetched, $tableNew)); |
There was a problem hiding this comment.
This test has no meaningful assertions
There was a problem hiding this comment.
(I know it causes an exception, but a "success" case should still be defined)
There was a problem hiding this comment.
What should it be? Something like
$this->assertTrue($tableNew->hasIndex('duplicate'));
$this->assertFalse($tableNew->hasIndex('test_idx'));?
There was a problem hiding this comment.
Something like that, yes. I think you don't need to work on it now, as @deeky666 is checking this particular issue himself after some internal discussion today.
I am not 100% sure, but I think the behavior exposed by this test is one of the factors in DBAL-1063. But even if it wasn't, it is still very confusing that
Table::getIndexesdoesn't return the same thing asSchemaManager::listTableIndexeswhen they are both called on the same table.I've written the test against the MySQL SM, but I suspect the same might happen with other platforms as well