Quote the name of an index in the create table statement. #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@digilist needs a test case first |
digilist
force-pushed
the
master
branch
2 times, most recently
from
db9ebb0
to
08bab83
Compare
digilist
added a commit
to digilist/dbal
that referenced
this pull request
Nov 8, 2014
|
Yes, sry, you are absolutely right. I added the tests. |
| $table->addIndex(array('column1'), '`key`'); | ||
|
|
||
| $sql = $this->_platform->getCreateTableSQL($table); | ||
| $this->assertEquals($this->getQuotedNameInIndexSQL(), $sql); |
There was a problem hiding this comment.
You need to create an abstract protected getQuotedNameInIndexSQL() method in this class
There was a problem hiding this comment.
The method is declared in line 537. Or do I misinterpret your comment?
There was a problem hiding this comment.
Ah sorry didn't see that line. Nevermind then.
deeky666
added a commit
that referenced
this pull request
Jan 12, 2015
Quote the name of an index in the create table statement.
|
@digilist thanks! Backported to 2.5 and 2.4. |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the method
getCreateTableSQLall names of tables, columns and foreign keys are quoted but not the names of indexes. This PR fixes this problem.It would be very nice, if this fix can be backported into at least the 2.4 branch :)