Fixed quoting of string literals containing backslash #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
morozov
commented
Oct 24, 2018
•
morozov
commented
| Q | A |
|---|---|
| Type | bug |
| BC Break | no |
| Fixed issues | #3328 |
morozov
force-pushed
the
issues/3328
branch
2 times, most recently
from
55b409b
to
9978392
Compare
morozov
changed the title
Ocramius
previously requested changes
Oct 24, 2018
ostrolucky
approved these changes
Nov 11, 2018
|
@Ocramius unless there are other objections, I'm going to merge this tomorrow. Escaping was fixed at the lowest level use case which is covered by an integration test at the same level. If there's a higher level test case which is broken by the change, we'll have to identify and fix it separately. The lower level implementation stays as it's implemented here in any case. |
This was referenced Nov 22, 2018
morozov
added a commit
that referenced
this pull request
Nov 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.