Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Limit Query on SQLServer2012 with newline before ORDER BY #2428

Closed
wants to merge 3 commits into from
Closed

Modify Limit Query on SQLServer2012 with newline before ORDER BY #2428

wants to merge 3 commits into from

Conversation

stchr
Copy link

@stchr stchr commented Jun 29, 2016

Modify Limit Query on SQLServer2012 with newline before ORDER BY

@deeky666
Copy link
Member

/cc @billschaller

@alexislefebvre
Copy link

Is there a reason this PR has 3 commits? The first 2 commits seems unrelated. Maybe you should rebase this PR (depending on the choice from the admins of this repository).

@deeky666
Copy link
Member

deeky666 commented Jul 7, 2016

Yep should be rebased and squashed.

@Ocramius
Copy link
Member

Ocramius commented Jul 7, 2016

@billschaller if you can give me your 👍 or 👎 I can merge and rebase on merge

@billschaller
Copy link
Member

@Ocramius 👍

@Ocramius Ocramius changed the title master Modify Limit Query on SQLServer2012 with newline before ORDER BY Jul 11, 2016
Ocramius added a commit that referenced this pull request Jul 11, 2016
@Ocramius
Merge branch 'fix/#2428-sql-server-2012-newline-before-order-by-2.5' …
b896ddd 
…into 2.5

Close #2428
@Ocramius Ocramius closed this in 17f50b8 Jul 11, 2016
@Ocramius Ocramius added this to the 2.5.5 milestone Jul 11, 2016
@Ocramius Ocramius assigned Ocramius and unassigned billschaller Jul 11, 2016
@Ocramius
Copy link
Member

Merged, thanks!

master: 17f50b8
2.5: b896ddd

@morozov morozov mentioned this pull request Sep 9, 2016
Merged
@Ocramius Ocramius mentioned this pull request Oct 1, 2016
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Bug Query Limit/Offset Modification SQL Server
Projects
None yet
Milestone
2.5.5
Development

Successfully merging this pull request may close these issues.
5 participants
@stchr @deeky666 @alexislefebvre @Ocramius @billschaller