Improve overall DBAL raised Events documentation #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… onSchemaAlterTable
…moveColumn, OnSchemaAlterTableChangeColumn, OnSchemaAlterTableRenameColumn events
deeky666
changed the title
|
I need someone who reviews the content and grammar/typos for this PR. |
|
I still found no one for a review :-( |
|
@SenseException LGTM, thanks a lot, and sorry for not noticing the PR before! \o |
|
No prob, bob. Thank you for merging it. |
Ocramius
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the DBAL events aren't documented yet, so I created this PR to update the docs.
I contains just some basics of the schema events and I didn't go deeper into the additional SQL statements of the event args and the conditions when these are getting added to the queries and when not (preventDefault).
There aren't details of the execution order because I'm not sure if there is a defined fix order that is shared between the different platforms.
Is there anything that still needs more attention in the documentation?