Proxy: Added support for PHP 7 return & parameter type hints #376
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DCOM-294 We use Jira to track the state of pull requests and the versions they got |
Majkl578
force-pushed
the
php7/proxy-types
branch
from
0d562e4
to
3e7a7ff
Compare
| @@ -777,6 +777,22 @@ private function generateMethods(ClassMetadata $class) | |||
| } | |||
|
|
|||
| $methods .= $name . '(' . $this->buildParametersString($class, $method, $method->getParameters()) . ')'; | |||
|
|
|||
| if (PHP_VERSION_ID >= 70000 && $method->hasReturnType()) { | |||
There was a problem hiding this comment.
Can this be split into a private method?
Majkl578
force-pushed
the
php7/proxy-types
branch
from
3e7a7ff
to
79588c2
Compare
|
👍 |
| $this->markTestSkipped('Method return types are only supported in PHP >= 7.0.0.'); | ||
| } | ||
|
|
||
| $className = 'Doctrine\Tests\Common\Proxy\ReturnTypesClass'; |
There was a problem hiding this comment.
This can use PHP 5.6 ::class, right?
There was a problem hiding this comment.
No, that is a syntax error on PHP <5.5 (and this package is >=5.3.2).
There was a problem hiding this comment.
It would fail at parse time, fyi ;-)
There was a problem hiding this comment.
I realized, to bad :/
There was a problem hiding this comment.
Gonna change it anyway: bumping the library dependencies.
There was a problem hiding this comment.
Cool, let me know if/when you need rebase or other changes here.
|
@Ocramius: Is there anything else that needs to be done? |
|
@Majkl578 no, this looks good, but the patch has to wait for 2.6.0, so I'll first have to branch out 2.5.x to keep it stable. |
|
@Ocramius: Makes sense. 👍 (Hoping that 2.6 will be released when PHP 7 reaches stable release. :) ) |
|
Can haz PHP 7 support plz? Yes, we can, thanks to @Majkl578 :-) |
This PR adds support for PHP 7 return types and parameter type hints on generated proxies.