Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: remove the floating cookie widget, use button in footer #20976

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Sep 23, 2024

  • site: use the correct OneTrust ID
  • site: add cookie settings button

We were using an incorrect OneTrust ID. The ID should be the same as on Docker Hub and WWW. This might have been an outdated ID, not sure what the root cause is. But this changes the ID to the correct one, and adds the cookie button HTML in the footer, which should get rid of the floating widget.

The ID should be the same as what we use on Docker Hub and WWW (single
top-level domain, shared controls).

Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@github-actions github-actions bot added hugo Updates related to hugo area/config labels Sep 23, 2024
Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e845f42
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66f15c0114ff4d0008a9602b
😎 Deploy Preview https://deploy-preview-20976--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from a team September 23, 2024 12:17
Copy link
Member

@usha-mandya usha-mandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn dvdksn merged commit c56b0f2 into docker:main Sep 23, 2024
14 checks passed
@dvdksn dvdksn deleted the smite-cookie-widget branch September 23, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants