-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby on rails example for ruby docs #20412
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good. A few issues I ran into below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @falconcr. With the Compose file updates, the line highlighting formatting became misaligned.
Also, related to the ARM issue in GitHub Actions, do know if users using ARM chips on Apple M1/M2 will be able to build locally?
Hello @craig-osterhout , I applied the lastest feedback and about your question, yes they can. I requested one friend to build the image following the code repo and was able, he has a Apple M1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
* Update ruby folder * Add deploy file * Update deploy * Update database * Update files from codereview * Update develop md * Add whales * Add env file * Apply changes * Apply feedback from craig * Delete mr64 * apply feedback
Description
This pull request introduces a comprehensive guide for Dockerizing a Ruby on Rails application. The guide is intended to help developers quickly and easily containerize their Rails apps, ensuring consistent environments and simplifying deployment processes.
Overview
Related issues or tickets
N/A
Reviews
@craig-osterhout
@usha-mandya