Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby on rails example for ruby docs #20412

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Conversation

falconcr
Copy link
Contributor

@falconcr falconcr commented Jul 15, 2024

Description

This pull request introduces a comprehensive guide for Dockerizing a Ruby on Rails application. The guide is intended to help developers quickly and easily containerize their Rails apps, ensuring consistent environments and simplifying deployment processes.

Overview

  • Setting up Docker and Docker Compose
  • Creating a Dockerfile for a Rails application
  • Configuring Docker Compose for development and production environments
  • Running and managing Dockerized Rails applications
  • Testing the app in kubernetes by docker for desktop app.

Related issues or tickets

N/A

Reviews

@craig-osterhout
@usha-mandya

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit e20e824
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/66a9669bbc81dc0008e2db8f
😎 Deploy Preview https://deploy-preview-20412--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/language/ruby/containerize.md Outdated Show resolved Hide resolved
content/language/ruby/containerize.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/containerize.md Outdated Show resolved Hide resolved
content/language/ruby/containerize.md Outdated Show resolved Hide resolved
content/language/ruby/containerize.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
@falconcr falconcr requested a review from dvdksn July 17, 2024 19:43
@craig-osterhout craig-osterhout requested a review from a team July 24, 2024 15:03
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. A few issues I ran into below.

content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/deploy.md Outdated Show resolved Hide resolved
content/language/ruby/deploy.md Outdated Show resolved Hide resolved
content/language/ruby/deploy.md Show resolved Hide resolved
content/language/ruby/deploy.md Outdated Show resolved Hide resolved
content/language/ruby/deploy.md Outdated Show resolved Hide resolved
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @falconcr. With the Compose file updates, the line highlighting formatting became misaligned.
Also, related to the ARM issue in GitHub Actions, do know if users using ARM chips on Apple M1/M2 will be able to build locally?

content/language/ruby/develop.md Outdated Show resolved Hide resolved
content/language/ruby/develop.md Outdated Show resolved Hide resolved
@falconcr
Copy link
Contributor Author

Thanks, @falconcr. With the Compose file updates, the line highlighting formatting became misaligned. Also, related to the ARM issue in GitHub Actions, do know if users using ARM chips on Apple M1/M2 will be able to build locally?

Hello @craig-osterhout , I applied the lastest feedback and about your question, yes they can. I requested one friend to build the image following the code repo and was able, he has a Apple M1:

image

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

@craig-osterhout craig-osterhout merged commit 5a5ee25 into docker:main Jul 31, 2024
12 checks passed
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
* Update ruby folder

* Add deploy file

* Update deploy

* Update database

* Update files from codereview

* Update develop md

* Add whales

* Add env file

* Apply changes

* Apply feedback from craig

* Delete mr64

* apply feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/get-started Relates to get started and onboarding docs status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants