docs(compose): Inlude example for build secrets on the use-secrets doc #20403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/compose
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cefeboru
changed the title
cefeboru
changed the title
aevesdocker
reviewed
Jul 15, 2024
aevesdocker
approved these changes
Jul 15, 2024
elegantcoder
pushed a commit
to elegantcoder/docs
that referenced
this pull request
Aug 28, 2024
docker#20403) * docs: Inlude example for build secrets * Apply suggestions from code review --------- Co-authored-by: Allie Sadler <102604716+aevesdocker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I had a hard time figuring out how to define build secrets in the compose file. Even though it was really obvious once I found out how to do it, this small example can save minutes for other developers as they try to figure it out.
At a later time, I discovered this was also explained in the build section, but for some reason, it was hard for me to reach it. When googling
secretsanddocker composethis doc was the first one to appearReviews