-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FastAPI example for python docs #20396
Add FastAPI example for python docs #20396
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @estebanx64. Added some minor nits, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add python docker example based on fastapi app * Add gitignore example in python docs * ✏️ Fix port mapping in docker init section * ♻️ Edit refactor to map container ports from 5000-5001 to 8000-8001 * ✏️ Fix some grammatical structures * 📝 Add some notes about kubernetes stuff
Description
Provide an example with one of the most used and modern python apps/frameworks today
FastAPI
to replace the old Flask exampleReplaced the old flask app by a new modern FastAPI since FastAPI is more popular nowadays, modern and use the latest python types features. This change was requested and approved by Craig and Eva
Related issues or tickets
N/A
Reviews
N/A
@craig-osterhout
@usha-mandya