Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FastAPI example for python docs #20396

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

estebanx64
Copy link
Contributor

Description

Provide an example with one of the most used and modern python apps/frameworks today FastAPI to replace the old Flask example

Replaced the old flask app by a new modern FastAPI since FastAPI is more popular nowadays, modern and use the latest python types features. This change was requested and approved by Craig and Eva

Related issues or tickets

N/A

Reviews

N/A

@craig-osterhout
@usha-mandya

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 260a397
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/669be81457478b00083109d4
😎 Deploy Preview https://deploy-preview-20396--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from a team July 11, 2024 06:44
Copy link
Contributor

@falconcr falconcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @estebanx64. Added some minor nits, otherwise LGTM.

content/language/python/containerize.md Outdated Show resolved Hide resolved
content/language/python/deploy.md Outdated Show resolved Hide resolved
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craig-osterhout craig-osterhout merged commit f092419 into docker:main Jul 25, 2024
12 checks passed
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
* Add python docker example based on fastapi app

* Add gitignore example in python docs

* ✏️ Fix port mapping in docker init section

* ♻️ Edit refactor to map container ports from 5000-5001 to 8000-8001

* ✏️ Fix some grammatical structures

* 📝 Add some notes about kubernetes stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/get-started Relates to get started and onboarding docs status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants