Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGDOCS-2072b #20094

Merged
merged 4 commits into from
Jul 15, 2024
Merged

ENGDOCS-2072b #20094

merged 4 commits into from
Jul 15, 2024

Conversation

aevesdocker
Copy link
Contributor

Description

Replaces #19857

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/security area/extensions Relates to Docker Extensions area/admin Relates to Docker Admin hugo Updates related to hugo labels May 23, 2024
@netlify Netlify
Copy link

netlify bot commented May 23, 2024 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 99a29f6
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6690fb9d4b82030008320d1f
😎 Deploy Preview https://deploy-preview-20094--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker added this to the 4.31 milestone May 23, 2024
stephaurelio
stephaurelio approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@stephaurelio stephaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💹

@aevesdocker aevesdocker modified the milestones: 4.31, 4.32 Jun 3, 2024
@aevesdocker aevesdocker modified the milestones: 4.32, 4.33 Jul 4, 2024
@aevesdocker aevesdocker removed this from the 4.33 milestone Jul 11, 2024
@aevesdocker aevesdocker requested a review from a team July 11, 2024 12:33
KatTomrushka
KatTomrushka approved these changes Jul 11, 2024
View reviewed changes
Copy link

@KatTomrushka KatTomrushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed via Slack.

craig-osterhout
craig-osterhout previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few nits added.

content/security/for-admins/enforce-sign-in/_index.md Outdated Show resolved Hide resolved
content/security/for-admins/enforce-sign-in/methods.md Outdated Show resolved Hide resolved
content/security/for-admins/enforce-sign-in/methods.md Outdated Show resolved Hide resolved
content/security/for-admins/enforce-sign-in/methods.md Outdated Show resolved Hide resolved
@aevesdocker aevesdocker merged commit b904b7f into docker:main Jul 15, 2024
11 of 12 checks passed
elegantcoder pushed a commit to elegantcoder/docs that referenced this pull request Aug 28, 2024
@aevesdocker @elegantcoder
ENGDOCS-2072b (docker#20094)
c34566a 
* ENGDOCS-2072b

* final tweaks

* review edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-osterhout craig-osterhout craig-osterhout approved these changes

@stephaurelio stephaurelio stephaurelio approved these changes

@KatTomrushka KatTomrushka KatTomrushka approved these changes

Assignees
No one assigned
Labels
area/admin Relates to Docker Admin area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/extensions Relates to Docker Extensions area/hub Issue affects Docker Hub area/security hugo Updates related to hugo status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aevesdocker @craig-osterhout @stephaurelio @KatTomrushka