Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix opentelemetry #11845

Merged
merged 1 commit into from
May 23, 2024
Merged

fix opentelemetry #11845

merged 1 commit into from
May 23, 2024

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented May 23, 2024

What I did
Do not capture Tracer in a var as TracerProvider get updated (twice) during the command PreRun

Related issue
https://docker.atlassian.net/browse/COMP-584

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested review from a team, glours and jhrotko and removed request for a team May 23, 2024 12:46
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 7ad73c2 into docker:main May 23, 2024
28 checks passed
@ndeloof ndeloof deleted the fix_otel branch May 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants