Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant goroutine while removing containers #10449

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

TP-O
Copy link
Contributor

@TP-O TP-O commented Apr 7, 2023

What I did
Method removeContainers creates a goroutine for each removed container. With that goroutine, it also creates one more goroutine to stop the container before removing it (can be completed without creating goroutine). I still remove the created redundant goroutine.

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@TP-O TP-O force-pushed the redundant-goroutine-while-removing-containers branch 4 times, most recently from 3070340 to eb69929 Compare April 7, 2023 02:53
@TP-O TP-O marked this pull request as ready for review April 7, 2023 02:53
@milas milas self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.08 🎉

Comparison is base (1fb0c03) 59.81% compared to head (d94ef4f) 59.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10449      +/-   ##
==========================================
+ Coverage   59.81%   59.90%   +0.08%     
==========================================
  Files         105      105              
  Lines        9074     9056      -18     
==========================================
- Hits         5428     5425       -3     
+ Misses       3076     3066      -10     
+ Partials      570      565       -5     
Impacted Files Coverage Δ
pkg/compose/compose.go 67.10% <0.00%> (+1.72%) ⬆️
pkg/compose/start.go 53.76% <0.00%> (-0.55%) ⬇️
pkg/compose/down.go 69.12% <69.23%> (+0.60%) ⬆️
pkg/compose/pull.go 76.72% <100.00%> (+2.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: TP-O <letranphong2k1@gmail.com>
@TP-O TP-O force-pushed the redundant-goroutine-while-removing-containers branch from eb69929 to d94ef4f Compare April 15, 2023 06:18
@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team April 17, 2023 12:09
@milas milas merged commit 0e7e1b9 into docker:v2 Apr 17, 2023
@TP-O TP-O deleted the redundant-goroutine-while-removing-containers branch April 18, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants