Skip to content
This repository has been archived by the owner on Feb 14, 2022. It is now read-only.

Update to Go 1.16 #183

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Update to Go 1.16 #183

merged 3 commits into from
Jan 28, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah force-pushed the update_golang branch 2 times, most recently from 1e00d3d to e5f2475 Compare January 28, 2022 14:44
@thaJeztah
Copy link
Member Author

Probably needs a more current version of Docker Engine to run the newer alpine / debian images (otherwise seccomp may be blocking some syscalls);

Step 22/51 : RUN make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark
 ---> Running in bb8946581e31
make: /bin/sh: Operation not permitted
make: /bin/sh: Operation not permitted
make: /bin/sh: Operation not permitted
make: /bin/sh: Operation not permitted
common.mk:21: unable to set BUILDTIME. Set the value manually
make: /bin/sh: Operation not permitted
make: /bin/sh: Operation not permitted
make: *** [Makefile:41: FORCE] Error 127
The command '/bin/sh -c make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark' returned a non-zero code: 2
make: *** [docker.Makefile:73: dockereng/kube-compose-controller] Error 2

@thaJeztah thaJeztah force-pushed the update_golang branch 2 times, most recently from a93d3c0 to 4be84cf Compare January 28, 2022 14:56
Older versions may have issues when running recent Alpine images,
due to seccomp profiles not being up to date with latest kernels.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the update_golang branch 2 times, most recently from 78ed796 to af69d3e Compare January 28, 2022 15:35
Hoping to fix:

    Output from proc 3:
      flag provided but not defined: -ginkgo.timeout
      Usage of /e2e.test:
        -alsologtostderr
          	log to standard error as well as files
        -ginkgo.dryRun
          	If set, ginkgo will walk the test hierarchy without actually running anything.  Best paired with -v.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov-commenter
Copy link

Codecov Report

Merging #183 (6c50f0c) into master (bb840f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   65.02%   65.02%           
=======================================
  Files          90       90           
  Lines       10958    10958           
=======================================
  Hits         7125     7125           
  Misses       3537     3537           
  Partials      296      296           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68fc5dc...6c50f0c. Read the comment docs.

Copy link
Member

@rumpl rumpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thaJeztah thaJeztah merged commit fd960f1 into docker:master Jan 28, 2022
@thaJeztah thaJeztah deleted the update_golang branch January 28, 2022 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants