Skip to content

Commit

Permalink
Merge pull request #2424 from jaihwan104/exit-1-when-manifest-merge-f…
Browse files Browse the repository at this point in the history
…ailed

fix exit code when manifest merge failed
  • Loading branch information
tonistiigi authored Apr 24, 2024
2 parents 699fa43 + f282351 commit 771e66b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion build/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s
}

if pushNames != "" {
progress.Write(pw, fmt.Sprintf("merging manifest list %s", pushNames), func() error {
err := progress.Write(pw, fmt.Sprintf("merging manifest list %s", pushNames), func() error {
descs := make([]specs.Descriptor, 0, len(res))

for _, r := range res {
Expand Down Expand Up @@ -637,6 +637,9 @@ func BuildWithResultHandler(ctx context.Context, nodes []builder.Node, opt map[s
}
return nil
})
if err != nil {
return err
}
}
return nil
})
Expand Down
4 changes: 3 additions & 1 deletion util/progress/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type Writer interface {
ClearLogSource(interface{})
}

func Write(w Writer, name string, f func() error) {
func Write(w Writer, name string, f func() error) error {
dgst := digest.FromBytes([]byte(identity.NewID()))
tm := time.Now()

Expand All @@ -40,6 +40,8 @@ func Write(w Writer, name string, f func() error) {
w.Write(&client.SolveStatus{
Vertexes: []*client.Vertex{&vtx2},
})

return err
}

func WriteBuildRef(w Writer, target string, ref string) {
Expand Down

0 comments on commit 771e66b

Please sign in to comment.