Perform more strict validation of *all* media types #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ bashbrew build ubuntu
Building bashbrew/cache:d7486128b40a58cd530279d02b41b6f8e7c873920ec7bc23610b89e2e7beae4b (ubuntu:18.04)
failed oci-import build of "ubuntu" (tags "18.04, bionic-20230126, bionic")
unsupported mediaType "application/vnd.docker.container.image.v1+json" for config descriptor "sha256:5d2df19066aca89df8e5317544a1cb599dc657830184762ff6fdefaaf708db65" (from directory "oci" in commit "4dd8c0973fccaf8699bac0a666f007b9d05c95fd") |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #64 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 7 7
Lines 714 714
=======================================
Hits 522 522
Misses 162 162
Partials 30 30 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
(I also tested this successfully against my older |
Docker media types inside OCI media types is semantically fine (and Docker sure doesn't care), but technically invalid, so this increases our validation from just the manifest media type all the way down to the config and layer media types also.
tianon
force-pushed
the
no-docker-inside-oci
branch
from
d4e9c45
to
057b598
Compare
yosifkit
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker media types inside OCI media types is semantically fine (and Docker sure doesn't care), but technically invalid, so this increases our validation from just the manifest media type all the way down to the config and layer media types also.
See also docker-library/official-images#13950 (comment) (docker-library/official-images#13983)