Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : CD 구축 #12

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Feat : CD 구축 #12

merged 2 commits into from
Aug 13, 2023

Conversation

guesung
Copy link
Collaborator

@guesung guesung commented Aug 12, 2023

💡 왜 PR을 올렸나요?

  • 신규 피처

💁 무엇이 어떻게 바뀌나요?

  1. 팀 repository로 vercel을 이용할 경우 금액이 발생합니다. 그래서 개인 repository로 clone > vercel로 자동 배포하는 식으로 구현하였습니다.
    • 추후에 AWS 배포 혹은 vercel 유료 이용하게 될 경우 CD를 수정하면 될 것 같습니다.

📆 작업 예정인 것이 있나요 ?

💬 리뷰어분들께

@guesung guesung requested a review from seondal as a code owner August 12, 2023 14:18
@guesung guesung self-assigned this Aug 12, 2023
@guesung guesung added the ✨ Feat 새로운 기능 개발 label Aug 12, 2023
@seondal
Copy link
Member

seondal commented Aug 13, 2023

앗 요 부분 저도 배포 확인하려고 fork한 개인 레포 vercel로 연결 해놨었는데 작업이 중복 된 것 같네요🫣

@guesung
Copy link
Collaborator Author

guesung commented Aug 13, 2023

앗 정말요 !..

@seondal seondal merged commit 15607d2 into develop Aug 13, 2023
@seondal seondal deleted the OZ-60-CD branch August 13, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seondal seondal seondal approved these changes

Assignees

@guesung guesung

Labels
✨ Feat 새로운 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guesung @seondal