Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Talk 페이지 구현 #11

Merged
merged 12 commits into from
Aug 13, 2023
Merged

Feat : Talk 페이지 구현 #11

merged 12 commits into from
Aug 13, 2023

Conversation

guesung
Copy link
Collaborator

@guesung guesung commented Aug 12, 2023

💡 왜 PR을 올렸나요?

  • 신규 피처

💁 무엇이 어떻게 바뀌나요?

  1. Talk 페이지를 구현하였습니다.
    스크린샷 2023-08-12 오전 9 19 42
  2. Header를 수정된 디자인에 맞게 수정하였습니다.
  3. Lottie Library를 추가하였습니다.
  4. Tooltip Library를 추가하였습니다.

📆 작업 예정인 것이 있나요 ?

  • Lottie 적용

💬 리뷰어분들께

@guesung guesung requested a review from seondal as a code owner August 12, 2023 00:20
@guesung guesung self-assigned this Aug 12, 2023
@guesung guesung added PoseTalk 💬 포즈톡 기능 관련 ✨ Feat 새로운 기능 개발 labels Aug 12, 2023
@guesung guesung added this to the DND Final Project ⛳️ milestone Aug 12, 2023
Copy link
Member

@seondal seondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 !

Comment on lines 1 to 15
import type { StrictPropsWithChildren } from '@/types';

export default function BottomFixedDiv({ children }: StrictPropsWithChildren) {
interface BottomFixedDivProps {
className?: string;
}

export default function BottomFixedDiv({
children,
className,
}: StrictPropsWithChildren<BottomFixedDivProps>) {
return (
<div className="fixed inset-x-0 bottom-0 mx-auto max-w-440">
<div className={`fixed inset-x-0 bottom-0 mx-auto max-w-440 ${className}`}>
<div className="px-20 pb-20">{children}</div>
</div>
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bottom fixed 어떻게 하기로 했었나요...? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하단에 고정하는 컴포넌트입니다 !

@guesung guesung merged commit 3fa1949 into develop Aug 13, 2023
@guesung guesung deleted the OZ-36-F-pose-talk branch August 13, 2023 07:16
@seondal seondal restored the OZ-36-F-pose-talk branch August 13, 2023 12:17
@seondal seondal deleted the OZ-36-F-pose-talk branch August 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feat 새로운 기능 개발 PoseTalk 💬 포즈톡 기능 관련
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants