Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependencies): move babel-plugin-macros to optional peer #60

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

Haroenv
Copy link
Collaborator

@Haroenv Haroenv commented Jul 18, 2023

fixes #47

In the strictest sense, this is a breaking change, but I don't think this is realistic, as someone using babel-plugin-macros only through the transitive dependencies of this package would be rare

fixes #47

In the strictest sense, this is a breaking change, but I don't think this is realistic, as someone using babel-plugin-macros only through the transitive dependencies of this package would be rare
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I agree this can be considered a minor version rather than major. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 59a511b into main Jul 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix/remove-dependency branch July 18, 2023 13:12
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jul 18, 2023
JoshuaKGoldberg added a commit that referenced this pull request Jul 18, 2023
Contains:

* #60
@JoshuaKGoldberg
Copy link
Collaborator

Released as dedent@1.2.0 👍

JoshuaKGoldberg added a commit that referenced this pull request Feb 18, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #88
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/dmnd/dedent/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/dmnd/dedent/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Re-applies #60 per the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

babel-plugin-macros should be an optional peer dependency
2 participants