Use dlopen to load NCCL.
#9796
Merged
Use dlopen to load NCCL.
#9796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rongou @hcho3 @RAMitchell @jakirkham This is ready for review now. Please take a look when you are available. ;-) |
|
cc @WeichenXu123 . |
|
I can work on conda-forge/xgboost-feedstock#150 (comment) after this PR. |
trivialfis
commented
Nov 21, 2023
rongou
reviewed
Nov 21, 2023
rongou
approved these changes
Nov 21, 2023
RAMitchell
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional support for loading nccl with
dlopenas an alternative of compile time linking. This is to address the size bloat issue with the PyPI binary release.ncclat runtime.After this,
ncclwill be fetched from PyPI when using pip to install XGBoost, either by user or bypyproject.toml. Others who want to link the nccl at compile time can continue to do so without any change.At the moment, this is Linux only since we only support MNMG on Linux.