Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JVM-Package to access inplace predict method #9167

Merged
merged 24 commits into from
Sep 11, 2023

Commits on May 16, 2023

  1. Logging in cpu predictor (+23 squashed commits)

    Squashed commits:
    [2aa500b] Try a different way of creating the proxy
    [c92d2df] try only one path
    [2f81ff3] dMatrix Handle null check and more statments
    [2e6df6f] exit on entering ifs
    [688fc73] More null checks
    [3e37688] change error logging
    [710dae5] missing semicolon
    [489c337] Put checks back in, change check in c_api
    [ad5972d] time to break the cpu predictor
    [7dfa3c0] No more check, do it live
    [abd64ff] dereference for logging
    [eb4cd9a] See if we can log what the type for proxy is
    [74c4376] maybe log something
    [a367ca2] uncomment for test, pass dMatrix through Booster.java
    [3e98f14] comment out for testing
    [66f0d8c] Changes to tests
    [737b293] some more changes to test
    [b3796b7] a dMatrix for testing
    [e995228] Convert long to handle
    [66ca8c3] c h e c k s t y l e
    [14f2243] Checkstyle failure
    [163bfca] missing comma
    [c869a14] First try at getting dMatrix logic into changes
    StephanTLavavej authored and yoquinjo committed May 16, 2023
    Configuration menu
    Copy the full SHA
    c5d448e View commit details
    Browse the repository at this point in the history
  2. Clean up some comments (+5 squashed commits)

    Squashed commits:
    [99b8f1f] Remove pom change
    [7b80fef] Remove changes from cpu_predictor, fix rebase miss
    [a531053] Cleaning up XGBoosterInplacePredict
    
    Further de-newification
    
    More clean-up
    [de6e109] pom change git didn't pick up (+5 squashed commits)
    Squashed commits:
    [6182244] One missed pom
    [ab5bc5e] Update all the poms, even the unused ones
    [a96c3b9] More clean-up
    [aea9cd3] Further de-newification
    [1539100] Cleaning up XGBoosterInplacePredict
    [a81361d] increment our version (+15 squashed commits)
    Squashed commits:
    [c4d6d52] missed param
    [b343f89] Remove redundant line
    [5609102] Remove need to pass DMatrix
    [e31c53d] another missed logging message
    [f6a2508] comment out some logging
    [148e29e] undo static cast
    [6372805] More logging
    [a173763] change how proxy is cast in cpu predictor
    [5a08ff8] proxy to stuff
    [823c92f] Dense adapter changes
    [9a3214b] change some variables and things
    [d9dd5c4] uncomment stuff, more logging
    [7968bca] Set dense data
    [9e79c2e] Try some stuff with DMatrix
    [2b8cca6] Print result of p_m.get()
    yoquinjo committed May 16, 2023
    Configuration menu
    Copy the full SHA
    ee0a029 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Additional documentation (+3 squashed commits)

    Squashed commits:
    [3e181c8] Remove missed comment
    [93ed445] Replace single piped equals in inplace predict
    [fc9b1d4] Remove ArrayComparator in java inplace predict test for junit assertion
    yoquinjo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    5ce8d65 View commit details
    Browse the repository at this point in the history
  2. Formatting

    yoquinjo committed May 18, 2023
    Configuration menu
    Copy the full SHA
    058aec3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    79ce356 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Configuration menu
    Copy the full SHA
    86e38d4 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Configuration menu
    Copy the full SHA
    0c5b2df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    312c874 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Configuration menu
    Copy the full SHA
    bed3035 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    57d88da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b923c95 View commit details
    Browse the repository at this point in the history
  3. jni

    trivialfis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3b88aaf View commit details
    Browse the repository at this point in the history
  4. test.

    trivialfis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e132136 View commit details
    Browse the repository at this point in the history
  5. cleanup.

    trivialfis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d623163 View commit details
    Browse the repository at this point in the history
  6. win.

    trivialfis committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e4f5ef8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. cleanup.

    trivialfis committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    bccd539 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge pull request #9 from trivialfis/jvm-inplace-predict

    Jvm inplace predict
    yoquinjo committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8b4885d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Configuration menu
    Copy the full SHA
    30ed3ca View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. EXDS-35- Cleaned up inplace_predict test. Refactored into two separat…

    …e tests: inplacePredictTest and inplacePredictMultiPredictTest. Extracted common logic of generating random data sets into generateRandomDataSet method. Added new test inplacePredictWithMarginTest which should test the utilization of a margin when performing predictions.
    ByteSizedJoe committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    509c880 View commit details
    Browse the repository at this point in the history
  2. EXDS-35- Modified iteration range to use [0,10] since the number of r…

    …ounds that we're training on is 10, and we want to use all rounds arbitrarily for this test.
    ByteSizedJoe committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    272ed03 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. EXDS-35 - Added a few clarifying comments, explicitly defined iterati…

    …on_range as iterationRange, so it is clear. Set this iteration range to [0,0) which mimics the calls in inplace_predict methods without margin.
    ByteSizedJoe committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    cc8e79b View commit details
    Browse the repository at this point in the history
  2. EXDS-35 - Brought in trivial from dmlc's changes which include settin…

    …g the base_score as a parameter for the booster and asserting the values between the predict with margin and predict without margin are similar within a delta(since floating point calculations vary slighty)
    ByteSizedJoe committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    81c23c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    dec1375 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Configuration menu
    Copy the full SHA
    e91026a View commit details
    Browse the repository at this point in the history