Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPUTreeshap #6163

Merged
merged 5 commits into from
Sep 27, 2020
Merged

Update GPUTreeshap #6163

merged 5 commits into from
Sep 27, 2020

Conversation

RAMitchell
Copy link
Member

  • Enable feature interactions

  • Reduce python test time

  • Add integration test with shap library

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #6163 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6163      +/-   ##
==========================================
+ Coverage   78.83%   78.91%   +0.08%     
==========================================
  Files          12       12              
  Lines        3090     3102      +12     
==========================================
+ Hits         2436     2448      +12     
  Misses        654      654              
Impacted Files Coverage Δ
python-package/xgboost/data.py 56.80% <0.00%> (+0.19%) ⬆️
python-package/xgboost/dask.py 81.07% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ef553...4d3fdd3. Read the comment docs.

src/predictor/gpu_predictor.cu Outdated Show resolved Hide resolved
unsigned ntree_limit,
std::vector<bst_float>* tree_weights,
bool approximate) override {
if (approximate) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need dispatching in gbm get predictor.

Copy link
Member Author

@RAMitchell RAMitchell Sep 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a benefit to explicitly failing, maybe the user is expecting the algorithm to use GPU and it is silently switching to CPU.

src/predictor/gpu_predictor.cu Outdated Show resolved Hide resolved
import unittest
import pytest

try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this into testing.py?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer it to stay here, I don't think it will be reused.

tests/python/test_with_shap.py Outdated Show resolved Hide resolved
@trivialfis
Copy link
Member

Can we close #5875 by this PR?

@RAMitchell RAMitchell merged commit dda9e1e into dmlc:master Sep 27, 2020
@trivialfis trivialfis mentioned this pull request Oct 10, 2020
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants