-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base margin dask #6155
Update base margin dask #6155
Conversation
Adds a few more things to #6132 |
* Address format. * Remove unused var.
Codecov Report
@@ Coverage Diff @@
## master #6155 +/- ##
==========================================
+ Coverage 78.83% 78.91% +0.08%
==========================================
Files 12 12
Lines 3090 3102 +12
==========================================
+ Hits 2436 2448 +12
Misses 654 654
Continue to review full report at Codecov.
|
@kylejn27 Could you please help taking a look into my last commit? |
@trivialfis looks great! Thanks for adding that in On a side note, are you using a python autoformatter like black? I'd love to install one for this project |
Thanks for the review. I believe XGBoost is using For auto formatting, I use yapf myself, but not a requirement for XGBoost. |
You can run |
Cool, I'll take a look at that, should make following style guidelines a bit easier. Black wanted to reformat everything completely differently 😞 |
Thanks for the PR! |
Add
base_margin
to sklearn predict and predict_probaAdd
output_margin
to sklearn predict and predict_probaAdd
base_margin
to sklearn fitUpdate
_get_worker_x_ordered
to_get_worker_parts_ordered
. This allows us to get ordered base_margin to create the DMatrix object used for dispatched_predictAdd dask test to confirm this is functioning correctly. Mirrors the same test in
test_with_sklearn