Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct style warnings from clang-tidy for rabit. #6095

Merged
merged 7 commits into from
Sep 8, 2020

Conversation

trivialfis
Copy link
Member

@trivialfis trivialfis commented Sep 8, 2020

This PR corrects most of the style warnings from tidy. Other warnings will be addressed in a different PR.

  • thread local is removed.

@hcho3
Copy link
Collaborator

hcho3 commented Sep 8, 2020

@trivialfis How did you run clang-tidy? We should modify CI to run clang-tidy for Rabit as well.

@trivialfis
Copy link
Member Author

trivialfis commented Sep 8, 2020

@hcho3 I modified the tests/ci_build/tidy.py script. There are other more serious warnings like zero division and null pointer dereference so I can't run it on CI yet.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #6095 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6095      +/-   ##
==========================================
+ Coverage   78.52%   78.62%   +0.09%     
==========================================
  Files          12       12              
  Lines        3069     3069              
==========================================
+ Hits         2410     2413       +3     
+ Misses        659      656       -3     
Impacted Files Coverage Δ
python-package/xgboost/tracker.py 95.18% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c55a3...fff3260. Read the comment docs.

@trivialfis trivialfis merged commit b0001a6 into dmlc:master Sep 8, 2020
@trivialfis trivialfis deleted the rabit-tidy branch September 8, 2020 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants