-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rabit update. #5978
Merged
Merged
Rabit update. #5978
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule rabit
updated
10 files
+5 −18 | include/rabit/internal/utils.h | |
+49 −34 | src/allreduce_base.cc | |
+2 −0 | src/allreduce_base.h | |
+7 −6 | src/allreduce_robust.cc | |
+0 −5 | src/engine_empty.cc | |
+2 −6 | src/engine_mpi.cc | |
+1 −0 | test/cpp/CMakeLists.txt | |
+2 −2 | test/cpp/allreduce_mock_test.cc | |
+4 −3 | test/cpp/allreduce_mock_test.cpp | |
+6 −0 | test/cpp/test_utils.cc |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, as I commented in dmlc/rabit#143, this is something we do need to implement current error handling strategy
regarding #4826 , what's your current plan? I think we could replace "kill SparkContext" with "kill the corresponding job" in the case of a task failure in JVM layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CodingCat It's still on early planing stage and I'm obviously not the right person to talk about spark, so my thought will be largely based on experience with dask. For spark specific things I usually just forward to @wbo4958 ;-). I have a few plans that I haven't decided on which one to go yet. They can be roughly listed as follow:
Sounds good to me. Whatever that doesn't interrupt the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way, the
exit(-1)
call has to go, as we need a proper exception.