Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that LoadSequentialFile() actually read the whole file #5831

Merged
merged 13 commits into from
Jul 4, 2020
Merged

Ensure that LoadSequentialFile() actually read the whole file #5831

merged 13 commits into from
Jul 4, 2020

Commits on Jun 27, 2020

  1. Ensure that the whole file is read by LoadSequentialFile()

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    6810799 View commit details
    Browse the repository at this point in the history

  2. Improve error handling in JSON when NUL letter is encountered

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    5a5f99c View commit details
    Browse the repository at this point in the history

  3. Add a unit test for LoadSequentialFile()

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    469705b View commit details
    Browse the repository at this point in the history

  4. Do not use fseek() / ftell() to measure file size

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    c8fabb2 View commit details
    Browse the repository at this point in the history

  5. Use ofstream in the unit test for exception safety

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    5083ca2 View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    efc6f47 View commit details
    Browse the repository at this point in the history

  7. Trim extra NUL letters from the end of buffer

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    d57e0ab View commit details
    Browse the repository at this point in the history

  8. Remove a comment

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    4782c7d View commit details
    Browse the repository at this point in the history

  9. Allow use of /dev/shm inside Docker container

    @hcho3
    hcho3 committed Jun 27, 2020
    Configuration menu
    Copy the full SHA
    2685ce6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Address reviewer's feedback

    @hcho3
    hcho3 committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    29708e9 View commit details
    Browse the repository at this point in the history

  2. Request correct number of bytes

    @hcho3
    hcho3 committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    7bb99c6 View commit details
    Browse the repository at this point in the history

  3. Add back an assertion

    @hcho3
    hcho3 committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    4faae5b View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2020

  1. Use std::ifstream.read() for all cases

    @hcho3
    hcho3 committed Jun 29, 2020
    Configuration menu
    Copy the full SHA
    c4b7ffa View commit details
    Browse the repository at this point in the history