Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split learner with composition. #5404

Closed
wants to merge 6 commits into from
Closed

Split learner with composition. #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7454500
Split up configuration.
trivialfis Feb 23, 2020
baff21c
Rebase.
trivialfis Mar 10, 2020
fb956bc
Fix rebase.
trivialfis Mar 10, 2020
f98ab22
Typo.
trivialfis Mar 10, 2020
f8eaaf6
Comments.
trivialfis Mar 10, 2020
7ba10a9
Minor refactor.
trivialfis Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions include/xgboost/learner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class Learner : public Model, public Configurable, public rabit::Serializable {
/*!
* \return whether the model allow lazy checkpoint in rabit.
*/
bool AllowLazyCheckPoint() const;
virtual bool AllowLazyCheckPoint() const = 0;
/*!
* \brief dump the model in the requested format
* \param fmap feature map that may help give interpretations of feature
Expand All @@ -199,16 +199,6 @@ class Learner : public Model, public Configurable, public rabit::Serializable {
* \return Key-value pairs representing configuration arguments
*/
virtual const std::map<std::string, std::string>& GetConfigurationArguments() const = 0;

protected:
/*! \brief objective function */
std::unique_ptr<ObjFunction> obj_;
/*! \brief The gradient booster used by the model*/
std::unique_ptr<GradientBooster> gbm_;
/*! \brief The evaluation metrics used to evaluate the model. */
std::vector<std::unique_ptr<Metric> > metrics_;
/*! \brief Training parameter. */
GenericParameter generic_parameters_;
};

struct LearnerModelParamLegacy;
Expand Down
Loading