Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prediction cache to Learner. #5220

Merged
merged 3 commits into from
Feb 14, 2020
Merged

Move prediction cache to Learner. #5220

merged 3 commits into from
Feb 14, 2020

Commits on Feb 11, 2020

  1. Move prediction cache into Learner. 

    * Clean-ups

- Remove duplicated cache in Learner and GBM.
- Remove ad-hoc fix of invalid cache.
- Remove `PredictFromCache` in predictors.
- Remove prediction cache for linear altogether, as it's only moving the
  prediction into training process but doesn't provide any actual overall speed
  gain.
- The cache is now unique to Learner, which means the ownership is no longer
  shared by any other components.

* Changes

- Add version to prediction cache.
- Use weak ptr to check expired DMatrix.
- Pass shared pointer instead of raw pointer.
    @trivialfis
    trivialfis committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    817ff54 View commit details
    Browse the repository at this point in the history

  2. Revert C API change.

    @trivialfis
    trivialfis committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    2bce357 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2020

  1. Prediction vector per matrix.

    @trivialfis
    trivialfis committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    4fcc43e View commit details
    Browse the repository at this point in the history