Add number of columns to native data iterator. #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
jvm-get-num-columns
branch
from
660f545
to
b43adc3
Compare
RAMitchell
approved these changes
Jan 15, 2020
|
We do something similar on dask, but delegate the task to np/pd. |
|
Pls don't merge. |
trivialfis
changed the title
|
Will wait for the corresponding jvm PR and merge them together. |
trivialfis
force-pushed
the
jvm-get-num-columns
branch
from
fa3282b
to
9131210
Compare
* Change native data iter into an adapter.
trivialfis
force-pushed
the
jvm-get-num-columns
branch
from
9131210
to
d0f0222
Compare
trivialfis
changed the title
RAMitchell
approved these changes
Feb 24, 2020
RAMitchell
reviewed
Feb 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps mitigating imputing sparse dataset from JVM package, where some columns might be completely missing. @wbo4958 will submit a follow up PR on JVM side.
For consistency and simplicity,
NativeDataIteris turned into an adapter.As a new data field is added, we break the ABI.