-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLOCKING] [jvm-packages] add gpu_hist and enable gpu scheduling #5171
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a519db5
[jvm-packages] add gpu_hist tree method
wbo4958 4df1950
change updater hist to grow_quantile_histmaker
wbo4958 dc0c6c5
add gpu scheduling
wbo4958 633baed
pass correct parameters to xgboost library
wbo4958 fd6eb08
remove debug info
wbo4958 9272f97
add use.cuda for pom
wbo4958 94936c2
add CI for gpu_hist for jvm
wbo4958 0361145
add gpu unit tests
wbo4958 990609b
use gpu node to build jvm
wbo4958 c7d588f
use nvidia-docker
wbo4958 581d0b0
Merge remote-tracking branch 'upstream/master' into gpu_hist
hcho3 da55a88
Add CLI interface to create_jni.py using argparse
hcho3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we really need two profile regarding gpu? mvn does support something like testing a particular suite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @CodingCat, Thx for the review.
I suppose "mvn does support something like testing a particular suite" is specifying like
Yeah, Seems mvn can specify which test suite to run, Suppose the test suite must be package name. So if PR has added another gpu related suites, then developer needs to change the CI build script to add another gpu suite.
This profile is only for CI used, and it will pick any suite tagged with GpuTestSuite to run. So the only thing for developer to do is just adding a GpuTestSuite tag to the new gpu suites, developer does not need to touch CI part, then everything will work as expected.