Hack for GPU ID config #5086
Merged
Hack for GPU ID config #5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnZed
reviewed
Dec 5, 2019
trivialfis
force-pushed
the
gpu-id-config
branch
from
ff68cb6
to
93bb4cb
Compare
|
I might implement a state machine for this configuration in next PR. |
|
@RAMitchell I will revert the changes in Learner if I can't get JSON in soon enough. |
|
Seems on Windows pipeline, if I stop the previous run, the next run will fail at getting sources. |
RAMitchell
approved these changes
Dec 5, 2019
trivialfis
force-pushed
the
gpu-id-config
branch
from
eb0c2d7
to
625f349
Compare
|
Back ported the changes in prediction cache from JSON PR. Added a small Python test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #5072 . The JSON PR works out everything, but being too huge. So continue the band-aid for rapids' release. @RAMitchell @JohnZed