Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building with shared NCCL. #4447

Merged
merged 1 commit into from
May 9, 2019
Merged

Enable building with shared NCCL. #4447

merged 1 commit into from
May 9, 2019

Conversation

trivialfis
Copy link
Member

close #4445

hcho3
hcho3 reviewed May 8, 2019
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
@hcho3
Copy link
Collaborator

hcho3 commented May 8, 2019

@jakirkham Can you try this pull request and see if it works for your use case?

@trivialfis
Copy link
Member Author

@jakirkham Combined with NCCL_ROOT env variable, this should be able to use system NCCL. If there are other issues in the platform you are packaging for please let me know, maybe I can help with that.

@trivialfis trivialfis merged commit 8da4907 into dmlc:master May 9, 2019
@jakirkham
Copy link
Contributor

Thanks for working on this. Sorry for being somewhat slow to reply. The patch does work nicely. Really appreciate the effort here.

@trivialfis trivialfis deleted the nccl branch May 9, 2019 16:12
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hcho3 hcho3 hcho3 left review comments

@RAMitchell RAMitchell RAMitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allowing dynamic linking of NCCL
4 participants
@trivialfis @hcho3 @jakirkham @RAMitchell