Commits on Apr 9, 2019

1. [jvm-packages] Fixing the NativeLibLoader on Java 9+ …

   The old NativeLibLoader had a short-circuit load path which modified
   java.library.path and attempted to load the xgboost library from outside
   the jar first, falling back to loading the library from inside the jar.
   This path is a no-op every time when using XGBoost outside of it's
   source tree. Additionally it triggers an illegal reflective access
   warning in the module system in 9, 10, and 11.
   
   On Java 12 the ClassLoader fields are not accessible via reflection
   (separately from the illegal reflective acces warning), and so it fails
   in a way that isn't caught by the code which falls back to loading the
   library from inside the jar.
   
   This commit removes that code path and always loads the xgboost library
   from inside the jar file as it's a valid technique across multiple JVM
   implementations and works with all versions of Java.

   

   Craigacp committed Apr 9, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 64eaa4f
   • Browse repository at this point

   Copy the full SHA

   64eaa4f View commit details

   Browse the repository at this point in the history