Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add external Docker build cache #4331

Merged
merged 8 commits into from
Apr 4, 2019
Merged

[CI] Add external Docker build cache #4331

merged 8 commits into from
Apr 4, 2019

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Apr 4, 2019 •
edited
Loading

  • Upgrade CMake to 3.8, as needed by Refactor CMake scripts. #4323 CMake upgrade has been postponed.
  • Add external Docker build cache, so that we can automatically cache builds from the latest Dockerfile. Docker caches are super important for speeding up CI builds. (Right now, I have to manually update the cache every time Dockerfile is updated.)

@hcho3 hcho3 changed the title Upgrade CMake + Add external Docker build cache [WIP] Upgrade CMake + Add external Docker build cache Apr 4, 2019
@hcho3 hcho3 marked this pull request as ready for review April 4, 2019 02:52
@hcho3 hcho3 changed the title [WIP] Upgrade CMake + Add external Docker build cache Upgrade CMake + Add external Docker build cache Apr 4, 2019
@hcho3 hcho3 changed the title Upgrade CMake + Add external Docker build cache Adopt CMake 3.8 + Add external Docker build cache Apr 4, 2019
@hcho3 hcho3 changed the title Adopt CMake 3.8 + Add external Docker build cache [CI] Adopt CMake 3.8 + Add external Docker build cache Apr 4, 2019
@trivialfis trivialfis mentioned this pull request Apr 4, 2019
Merged
6 tasks
@hcho3 hcho3 changed the title [CI] Adopt CMake 3.8 + Add external Docker build cache [CI] Add external Docker build cache Apr 4, 2019
@hcho3 hcho3 merged commit 37c75aa into dmlc:master Apr 4, 2019
@hcho3 hcho3 deleted the upgrade_cmake branch April 4, 2019 20:36
@hcho3 hcho3 mentioned this pull request Apr 4, 2019
Merged
@hcho3 hcho3 mentioned this pull request May 17, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivialfis trivialfis Awaiting requested review from trivialfis

@RAMitchell RAMitchell Awaiting requested review from RAMitchell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hcho3