Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the train and test input with same colnames. #4329

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

JiaxiangBU
Copy link
Contributor

Fix the bug report of #4328.
I am the beginner of the Git so just try my best to follows the guide, https://xgboost.readthedocs.io/en/latest/contribute.html#r-package.
I find there is no dev branch, so I pull this fix from my master branch to the original master branch.

Fix the bug report of dmlc#4328.
I am the beginner of the Git so just try my best to follows the guide, https://xgboost.readthedocs.io/en/latest/contribute.html#r-package.
I find there is no `dev`  branch, so I pull this fix from my master branch to the original master branch.
Copy link
Collaborator

@hcho3 hcho3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@hcho3 hcho3 merged commit 1ca5698 into dmlc:master Apr 4, 2019
@JiaxiangBU
Copy link
Contributor Author

JiaxiangBU commented Apr 5, 2019

Hi, @hcho3 Thanks for this merge.
Follow this guide, I also update CONTRIBUTORS.md. #4335

@lock lock bot locked as resolved and limited conversation to collaborators Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants