Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of a few trivial compiler warnings. #4312

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Get rid of a few trivial compiler warnings. #4312

merged 1 commit into from
Mar 30, 2019

Conversation

omo
Copy link
Contributor

@omo omo commented Mar 29, 2019

Mostly about adjusting types.

@trivialfis trivialfis self-requested a review March 30, 2019 13:53
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #4312 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4312      +/-   ##
==========================================
+ Coverage   67.82%   67.82%   +<.01%     
==========================================
  Files         132      132              
  Lines       12201    12200       -1     
==========================================
  Hits         8275     8275              
+ Misses       3926     3925       -1
Impacted Files Coverage Δ
src/tree/updater_colmaker.cc 39.76% <ø> (+0.19%) ⬆️
src/tree/updater_basemaker-inl.h 63.59% <ø> (-0.18%) ⬇️
src/c_api/c_api.cc 23.53% <100%> (ø) ⬆️
src/data/sparse_page_dmatrix.cc 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea5b77...6e91f86. Read the comment docs.

@trivialfis trivialfis merged commit 680a1b3 into dmlc:master Mar 30, 2019
@omo
Copy link
Contributor Author

omo commented Mar 30, 2019

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants