-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Upgrade to GCC 5.3.1, CMake 3.6.0 #4306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK upgrading devtoolset should not affect binary compatibility.
Looks like GCC 5 has a newer version of libgomp, and it’s causing issues on Ubuntu 14.04 (version used by Travis CI). Should we revert this? @RAMitchell @trivialfis EDIT. Ubuntu 14.04 reached EOL last month |
@hcho3 please don't revert. They will upgrade the OS. It would be painful to add back those workarounds only to remove it few months later. |
@hcho3 Besides, even if we revert it, people still need to compile XGBoost themselves unless we push another release immediately. But the problem wouldn't be here if they compile XGBoost at the first place(the mismatch wouldn't happen). So reverting won't be much of help. |
@trivialfis Got it. I won’t revert it then |
Upgrade the Jenkins CI container to use GCC 5.3.1, in order to obtain complete C++11 support (along with
std::regex
),